Alpha Centauri 2

Sid Meier's Alpha Centauri & Alien Crossfire => Modding => Bug/Patch Discussion => Topic started by: Yitzi on March 14, 2013, 12:04:34 AM

Title: It seems that the "attacking along road" bonus always applies
Post by: Yitzi on March 14, 2013, 12:04:34 AM

In the course of testing my patch, I discovered that the "attacking along a road" bonus (if not set to 0) applies even when there is no road present.  So to fix whatever bug I'd accidentally introduced, I compared it to what happens in Kyrub's patch...and the same thing happens.  Same in Scient's.  (Due to a side effect of my work*, I am unable to test it with the no-official-patches version, so if someone else wants to, that would be appreciated.)

*In the course of my latest patch, I've moved around a few alphax variables, which will of course cause problems for earlier patches.  Scient's and Kyrub's patch allow enough access for me to get around that, but the no-official-patches version doesn't.

Title: Re: It seems that the "attacking along road" bonus always applies
Post by: Petek on March 14, 2013, 01:10:10 AM

Looks like this bug is present in the official patched versions, since it's mentioned in Darsnan/Rubin's Alpha(x) Guide (http://www.civgaming.net/smac/alphaxguide_v1_3.html). Is that what you were looking for, or were you interested in the versions with no patches whatsoever installed?

Title: Re: It seems that the "attacking along road" bonus always applies
Post by: scient on March 14, 2013, 06:52:37 AM

I actually patched this already for up coming release.

(http://i.imgur.com/tCHWM33.jpg)

Title: Re: It seems that the "attacking along road" bonus always applies
Post by: Yitzi on March 14, 2013, 01:49:08 PM

Quote from: scient on March 14, 2013, 06:52:37 AM

I actually patched this already for up coming release.

(http://i.imgur.com/tCHWM33.jpg)

Thanks.  However, could you change it to have that reference to DWORD PTR DS:[9497BC] have enough room for a MOVSX from a WORD instead?  The large part of my patch 2.0 is reducing the size that alphax RULES variables take up to make room for more, and that variable was moved to a WORD, so having room for a WORD would be necessary to combine it with my patch.  (As programmed, it's limited to values between -100 and 1000 if I remember correctly, so restriction to a WORD isn't an added limitation.)  Thanks.

(I also was using that area for other stuff in earlier patches, but those will no longer be needed in 2.0, so that won't be an issue.)

Title: Re: It seems that the "attacking along road" bonus always applies
Post by: gwillybj on March 14, 2013, 02:14:05 PM

It is correct that attack-along-road has always applied to all attacks when given a non-zero value, patched or not patched, so it has always been left at zero. Seems odd that something so basic to nearly all wargames was not fixed a long time ago.