Author Topic: Yitzi's unofficial SMAX patch 2.4c  (Read 6724 times)

0 Members and 1 Guest are viewing this topic.

Offline Yitzi

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #15 on: January 14, 2014, 12:48:23 PM »
Ok, thanks, it should be included in the next patch.

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #16 on: January 14, 2014, 08:04:21 PM »
I have found another minor bug that I can fix. This involves the weapon attack graphics. For some reason the attack graphics for the missile launcher appear as an energy weapon and the attack graphics for the Gatling Laser appear as though they are for a projectile weapon.

This bug can be fixed by changing mov ecx, terranx_.00787118 at address 0045144E to mov ecx, terranx_.00787124. Then you change mov ecx, terranx_.00787124 at address 0045145D to mov ecx, terranx_.00787118. Lastly, you simply swap the weapon names, attack and cost values in the Alphax.txt file. To save you time, I am attaching a copy of your most recent patched alphax file with the needed change.


Offline Yitzi

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #17 on: January 14, 2014, 10:46:52 PM »
Ok, thanks, but won't that also switch their locations in the unit workshop?  Or is that what the assembly changes you described deal with?

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #18 on: January 15, 2014, 02:30:46 AM »
Ok, thanks, but won't that also switch their locations in the unit workshop?  Or is that what the assembly changes you described deal with?

First, you are correct that these changes will cause the weapons to swap places in the unit workshop. In addition, these changes to the assembly fix the graphics placement without having to swap the weapon caviar files in the game folder. Lastly, the swapping of the missile launcher and gatling laser should have a neglibile effect on gameplay while still fixing the attack graphic bug that I described above.

Offline Geo

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #19 on: January 15, 2014, 09:15:25 AM »
I have found another minor bug that I can fix. This involves the weapon attack graphics. For some reason the attack graphics for the missile launcher appear as an energy weapon and the attack graphics for the Gatling Laser appear as though they are for a projectile weapon.

You have quick eyes you can see the difference.

This bug can be fixed by changing mov ecx, terranx_.00787118 at address 0045144E to mov ecx, terranx_.00787124. Then you change mov ecx, terranx_.00787124 at address 0045145D to mov ecx, terranx_.00787118. Lastly, you simply swap the weapon names, attack and cost values in the Alphax.txt file. To save you time, I am attaching a copy of your most recent patched alphax file with the needed change.
[/quote]

Simply swapping the caviar files wouldn't solve it?

Offline Yitzi

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #20 on: January 15, 2014, 04:51:11 PM »
Ok, thanks, but won't that also switch their locations in the unit workshop?  Or is that what the assembly changes you described deal with?

First, you are correct that these changes will cause the weapons to swap places in the unit workshop. In addition, these changes to the assembly fix the graphics placement without having to swap the weapon caviar files in the game folder. Lastly, the swapping of the missile launcher and gatling laser should have a neglibile effect on gameplay while still fixing the attack graphic bug that I described above.

Swapping their positions in the unit editor will indeed have negligible effect on gameplay, but so does the attack graphics bug; you're essentially trading one display bug for another, and the position-in-workshop one seems to be a bigger bug to me.  So I don't think this change is worth doing; if, however, you can find how to just fix the actual attack graphics with no detrimental side effects, I'd include it.

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #21 on: January 15, 2014, 06:09:50 PM »
Ok, thanks, but won't that also switch their locations in the unit workshop?  Or is that what the assembly changes you described deal with?

First, you are correct that these changes will cause the weapons to swap places in the unit workshop. In addition, these changes to the assembly fix the graphics placement without having to swap the weapon caviar files in the game folder. Lastly, the swapping of the missile launcher and gatling laser should have a neglibile effect on gameplay while still fixing the attack graphic bug that I described above.


Swapping their positions in the unit editor will indeed have negligible effect on gameplay, but so does the attack graphics bug; you're essentially trading one display bug for another, and the position-in-workshop one seems to be a bigger bug to me.  So I don't think this change is worth doing; if, however, you can find how to just fix the actual attack graphics with no detrimental side effects, I'd include it.

However, if you look at the order of the weapons in the flavor.txt file that is in the game folder, you can see that the gatling laser is placed after the missile launcher in the sequence of weapons. This leads me to believe that they had intended the gatling laser to be placed after the missile launcher for the purposes of graphics and gameplay.

Offline Yitzi

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #22 on: January 15, 2014, 06:15:28 PM »
However, if you look at the order of the weapons in the flavor.txt file that is in the game folder, you can see that the gatling laser is placed after the missile launcher in the sequence of weapons. This leads me to believe that they had intended the gatling laser to be placed after the missile launcher for the purposes of graphics and gameplay.

And then they changed their minds, probably because they realized that having the gatling laser be 5 attack, and the missile launcher 6, worked better than the other way around.

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #23 on: January 15, 2014, 06:19:28 PM »
However, if you look at the order of the weapons in the flavor.txt file that is in the game folder, you can see that the gatling laser is placed after the missile launcher in the sequence of weapons. This leads me to believe that they had intended the gatling laser to be placed after the missile launcher for the purposes of graphics and gameplay.

And then they changed their minds, probably because they realized that having the gatling laser be 5 attack, and the missile launcher 6, worked better than the other way around.

I will go with your final decision because this is your patch and you ultimately decide what to include or not.

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #24 on: January 16, 2014, 05:48:42 PM »
I think I have found another bug. This bug involves the map that appears when you select a unit and tell it to go to a specific destination. When the screen is first up you see a different map then the world map but if you click on Sort:Dist, Sort:Size, or Sort:Name then the alternate map is replaced by the standard world map and does not appear again unless reopen the window. A fast way to see this bug is by pressing G during the game and then follow the instructions above. If you need a before and after screenshot for the bugged screen, I will gladly supply them.   

Offline Yitzi

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #25 on: January 16, 2014, 07:10:37 PM »
I think I have found another bug. This bug involves the map that appears when you select a unit and tell it to go to a specific destination. When the screen is first up you see a different map then the world map but if you click on Sort:Dist, Sort:Size, or Sort:Name then the alternate map is replaced by the standard world map and does not appear again unless reopen the window. A fast way to see this bug is by pressing G during the game and then follow the instructions above. If you need a before and after screenshot for the bugged screen, I will gladly supply them.

That sounds likely to be a pain to fix and is too minor to make the short list, but feel free to provide screenshots (and if you want to work on a fix and let me know when you have one, go ahead).

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #26 on: January 17, 2014, 07:14:22 PM »
I am currently trying to find out exactly what is causing the map to disappear. Also, does anyone know the general underlying reason for why the road attack combat rule is bugged?

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #27 on: January 17, 2014, 07:48:42 PM »
Yuck. Another bug involving the exact same map. Here is a screen shot illustrating how the map does not cover the faction diplomacy landscape while you are trading bases. Note: I do believe the this map's proper development name was the political map because it shows a faction's territory.

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #28 on: January 17, 2014, 08:25:17 PM »
I have a hypothesis as to why the political map disappears and is replaced with the regular world map when you select sort dist, sort size etc. I think it has to do with the fact that the game either refreshes the screen after you press any of those buttons it freezes the map-cursor interface before you press those buttons. The reason it could be either of those options is because you are unable to move the cursor around the map before you select any of those options but afterwards you can move the cursor around the map.

Offline Dio

Re: Yitzi's unofficial SMAX patch 2.4c
« Reply #29 on: January 17, 2014, 08:59:46 PM »
I also noticed that their is coding for labels of buttons or selections such as zoom, auto off, and cancel destination. I think these where going to be features but they decided to cut them out by having the assembly language jump over them.
« Last Edit: January 17, 2014, 09:16:19 PM by Dio »

 

* User

Welcome, Guest. Please login or register.
Did you miss your activation email?


Login with username, password and session length

Select language:

* Community poll

SMAC v.4 SMAX v.2 (or previous versions)
-=-
18 (6%)
XP Compatibility patch
-=-
9 (3%)
Gog version for Windows
-=-
77 (29%)
Scient (unofficial) patch
-=-
28 (10%)
Kyrub's latest patch
-=-
14 (5%)
Yitzi's latest patch
-=-
85 (32%)
AC for Mac
-=-
2 (0%)
AC for Linux
-=-
5 (1%)
Gog version for Mac
-=-
10 (3%)
No patch
-=-
12 (4%)
Total Members Voted: 260
AC2 Wiki Logo

* Random quote

A ship at sea is its own world. To be the captain of a ship is to be the unquestionable ruler of that world and requires all of the leadership skills of a prince or minister.
~Col. Corazon Santiago 'Leadership and the Sea'

* Select your theme

*